Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
+ Coverage 91.40% 91.49% +0.08%
==========================================
Files 53 53
Lines 8381 8394 +13
==========================================
+ Hits 7661 7680 +19
+ Misses 720 714 -6
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image aggregation currently ignores
value_key: requesting"CD3"still aggregates every image channel. This change selects the requested channels before computing zonal statistics, so only those channels appear in the result.Channel order follows the request, while
value_key=Nonepreserves aggregation of all channels. The public signature, statistics, andchannel_<name>_<statistic>output names remain unchanged. Empty requests, duplicate requests, unknown channels, and non-unique image channel names raiseValueErrorwhen explicitly selecting channels.Regression tests cover single and multiscale images, hand-calculated mean/sum/count values, channel order, invalid requests, input preservation, region metadata, and the
SpatialData.aggregate()wrapper withzone_ids.Validation on Python 3.12.9:
pytest tests/core/operations/test_aggregations.py -q— 85 passed, 6 skipped.git diff --checkpassed.These are local checks; the full test suite and remote CI matrix have not been run. The separate
int8/uint8table-validation issue in #1229 is outside this change; the regression tests useint32labels.Fixes #274.