fix(datashader): handle zero-extent point sets instead of NaN canvas#728
Merged
Conversation
…724) A single point (or coincident points / an axis-aligned line) has zero spatial extent, so _compute_datashader_canvas_params computed factor=0 and then int(round(width / 0)) raised 'cannot convert float NaN to integer'. Pad any degenerate axis to a unit window centered on its value before deriving the canvas scale, so the data lands in a finite canvas and renders. Non-degenerate extents are passed through unchanged, so normal data is unaffected. Fixes #724.
timtreis
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 79.20% 79.21% +0.01%
==========================================
Files 17 17
Lines 4563 4566 +3
Branches 1026 1026
==========================================
+ Hits 3614 3617 +3
Misses 599 599
Partials 350 350
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #724.
render_points(method="datashader")on a single point (or coincident points, or an axis-aligned line) crashed withValueError: cannot convert float NaN to integer.