Skip to content

perf(shapes): drop the per-render table join when coloring by a table column #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtreis merged 1 commit into from
Jun 10, 2026
Merged

perf(shapes): drop the per-render table join when coloring by a table column #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/spatialdata_plot/pl/render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,8 +600,8 @@ def _render_shapes(

_check_obs_var_shadow(sdata, element, col_for_color, render_params.table_name)

# filter_tables=False: join_spatialelement_table below overwrites the table,
# so the cs-level sparse copy is wasted work.
# filter_tables=False: the annotating table is read directly below (color is resolved per shape
# from it, region-masked and reindexed), so the cs-level sparse table copy would be wasted work.
sdata_filt = sdata.filter_by_coordinate_system(
coordinate_system=coordinate_system,
filter_tables=False,
Expand All @@ -610,12 +610,11 @@ def _render_shapes(
table_name = render_params.table_name
if table_name is None:
table = None
shapes = sdata_filt[element]
else:
# No join/copy: _set_color_source_vec resolves each shape's color from the table (region-masked
# and reindexed to the element), so unannotated shapes keep their place and render with na_color.
_check_instance_ids_overlap(sdata_filt, table_name, element, sdata_filt[element].index)
joined_element, joined_table = _join_table_for_element(sdata, element, table_name)
sdata_filt[element] = shapes = joined_element
sdata_filt[table_name] = table = joined_table
table = sdata_filt[table_name]

shapes = sdata_filt[element]

Expand Down
Loading