Fix unbounded interval sampling, persistence, and Allen relations - #6
Merged
Conversation
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbounded intervals currently overflow overlap subtraction: debug builds panic, and release builds can silently reject every sampled candidate. This change saturates oversized overlap and finite-duration calculations at
i64::MAX, while preservingNonefor infinite durations. It also corrects the reversedFinishes/FinishedByrelations.Persistent ingestion exposed a related failure before sampling: the temporal index tries to allocate one entry per day across the entire interval. Intervals spanning more than 4,096 daily buckets now use one reserved bucket. Narrow queries include that bucket; broad queries scan existing index entries and filter by actual overlap. Existing day-indexed records remain readable without an index rebuild. Broad queries remain proportional to the stored index size.
Regression coverage includes all 13 Allen relations, extreme finite and infinite endpoints, deterministic sampling with
PersistentStore, temporal queries after restart, and unbounded batch ingestion and queries through a router and two persistent shards.Validation completed locally:
cargo test: 321 passed, two existing doctests ignored.cargo test --test distributed_e2e: both tests passed, including the subsequently added distributed regression.cargo test --release --test temporal_samplingpassed.cargo clippy --all-targets,cargo fmt --check, andgit diff --checkpassed.Fixes #4
Fixes #5