stop creeps on corner squares from changing rooms#72
Open
sparr wants to merge 1 commit intoscreeps:ptrfrom
Open
stop creeps on corner squares from changing rooms#72sparr wants to merge 1 commit intoscreeps:ptrfrom
sparr wants to merge 1 commit intoscreeps:ptrfrom
Conversation
artch
requested changes
Jan 7, 2018
Contributor
artch
left a comment
There was a problem hiding this comment.
This change is not enough, since bulk.update(object, {interRoom: {room, x, y}}); will still be executed. You have to change line 50 instead.
Contributor
Author
|
There are plenty of other places in the code where |
Contributor
|
|
Contributor
Author
|
Ahh, got it. I didn't realize that this wouldn't be a do-nothing call in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the more preferred solution, rather than rejected #52