Fix unspawned power creeps returning a weird null value for their TTL#148
Open
tiennou wants to merge 1 commit intoscreeps:masterfrom
Open
Fix unspawned power creeps returning a weird null value for their TTL#148tiennou wants to merge 1 commit intoscreeps:masterfrom
tiennou wants to merge 1 commit intoscreeps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #144 and the attached Discord discussion for details.
But in short, before the pcreep is spawned,
o.ageTimeis undefined — it gets defined by the spawnPowerCreep intent.Which leads to the
ticksToLiveproperty subtracting the current tick value fromundefined, which isNaN(no idea why, per the Discord discussion, thisNaNwould show up as a weirdly behavingnull).Fix the issue by checking that
o.ageTimeexists, and set it toundefinedwhen the pcreep dies.