constructionSites scan fewer objects#141
Open
asquared31415 wants to merge 1 commit intoscreeps:masterfrom
Open
constructionSites scan fewer objects#141asquared31415 wants to merge 1 commit intoscreeps:masterfrom
asquared31415 wants to merge 1 commit intoscreeps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of scanning all objects that the user has visibility on and checking their type, use the register that has been pre-sorted by type already. This means a maximum of 100 objects are scanned, rather than potentially thousands or tens of thousands.