Fix incorrect return types for Game.market.getHistory()#131
Open
SystemParadox wants to merge 1 commit intoscreeps:masterfrom
Open
Fix incorrect return types for Game.market.getHistory()#131SystemParadox wants to merge 1 commit intoscreeps:masterfrom
SystemParadox wants to merge 1 commit intoscreeps:masterfrom
Conversation
Prevent Game.market.getHistory() returning empty objects if resource is invalid or has no data. Return an empty array instead. Includes a similar fix for underlying code of Game.market.getAllOrders(), which only works correctly at the moment because of the `_.filter` call.
sparr
approved these changes
Jun 17, 2023
Contributor
sparr
left a comment
sparr
left a comment
There was a problem hiding this comment.
This appears to correctly match the expected and documented return type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent Game.market.getHistory() returning empty objects if resource is invalid or has no data. Return an empty array instead.
Includes a similar fix for underlying code of Game.market.getAllOrders(), which only works correctly at the moment because of the
_.filtercall.