Use range option in findClosestByPath#121
Open
RiftLurker wants to merge 1 commit intoscreeps:masterfrom
Open
Conversation
|
@o4kapuk Is there a reason this still isn't merged? |
|
Sorry for the rash question... 😅 Lines 367 to 371 in 78d980e The current implementation checks if the final position of the path is near to a target which wouldn't work if that final position if further away... Maybe inRangeTo would solve the problem, but then the result might not be distinct 🤔I'll give it more thought later 🙃 |
This was referenced Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120