Implement cache for active structures in rooms#107
Open
Flya wants to merge 4 commits intoscreeps:ptrfrom
Open
Conversation
Flya
force-pushed
the
ptr
branch
9 times, most recently
from
bf3e3dc to
175670c
Compare
|
@Flya i noticed that a |
Author
|
@semperrabbit Sorry looks like I missed to include this file. I have added this file now. |
Contributor
|
I have been told that this PR fixes the bug described in #140 where isActive can produce two different sets of results via the API and in the engine, resulting in inaccurate info being sent to the client and some rooms having fewer usable extensions than they should. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This committe is rework how game engine is calculate
isActivefor structures in room. The logic is implemented by using propertyoffin raw object. The processor will update this property in the end of the tick and runtime will use it for check if structure is active.