Skip to content

feat: complete personal study tools and refresh the app - #21

Merged
screen-gd merged 3 commits into
mainfrom
chore/trim-legacy
Nov 13, 2026
Merged

screen-gd merged 3 commits into
mainfrom
chore/trim-legacy

Conversation

@screen-gd

@screen-gd screen-gd commented Nov 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

Make Syllo usable as a complete personal study app: keep source-linked notes, build a glossary, revise with scheduled cards, and track learning progress. Give the app consistent panels, topic colours, count readouts, and useful empty states.

Learn or read
  -> save notes and glossary terms
  -> keep review cards and practise recall
  -> track completed lessons and daily progress

Includes the existing removal of unused marketing, gallery, sharing, billing, and legacy dashboard pages, plus the Bun workspace migration. The Bun changes overlap with PR https://git.cafe/screen/syllo/pulls/20; reconcile that overlap before merging both.

Evidence

  • Before: notes used the older route and there were no dedicated glossary or progress pages.
  • After: dedicated Notes, Glossary, and Progress pages, shared review collection, lesson completion tracking, and video recall checks.
  • bun run typecheck: passed, including Convex.
  • bun run lint: passed.
  • bun run test: 18 files and 94 tests passed.
  • bun run build: client and server production builds passed.
  • Latest remote main is already included in this branch.
  • Before-and-after screenshots are missing. Browser testing was not requested, so the visual result and narrow mobile layouts remain unverified.

Merge Danger

Door: two-way

Code changes can be reverted. Review the removal of public and legacy routes before merging. This also changes the package manager and adds a Scout SQLite table for recall checks.

Blast Radius: app-wide

Navigation, learning, reading, revision, styling, and local development commands. Check mobile rating buttons and accent colours visually.

Implemented in Claude Code, including Claude Opus 5.5. PR prepared with GPT-6.1 Sol in T3 Code through the Codex harness.


Devin Review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 05ef85d9-add3-438a-9a17-1c1c5d061f4a
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@devin-ai-integration devin-ai-integration Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.

Devin Review found 7 potential issues.

Devin Review

Comment thread apps/web/src/views/studio/progress.tsx Resolved
Comment thread apps/web/src/views/studio/reviews.tsx Resolved
Comment thread apps/web/src/views/studio/glossary.tsx Resolved
Comment thread apps/web/src/lib/learning.ts Resolved
@@ -0,0 +1,229 @@
import { Link } from "@tanstack/react-router";
import { ArrowRight } from "lucide-react";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 New icon imports use the barrel

The new study pages import icons from lucide-react, despite the repository's direct-import rule and no Vite rewrite.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not changed. Every existing component in apps/web/src imports icons from the lucide-react barrel, and Vite tree-shakes it in production builds. If we want direct imports, it should be one repo-wide change, not just these new pages.

Comment thread apps/web/src/routes/api/scout/checks.ts Resolved
Comment thread apps/web/src/lib/scout/video-checks.ts Resolved
- Count milestone lessons in roadmap stats
- Only show Return to source for cards with a recorded lesson
- Keep glossary review cards in step with term edits
- Save a completed lesson before counting it in the Learning Record
- Key cached recall checks by chapter labels as well as starts
- Reject cross-origin browser requests to /api and server functions

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Devin Review

Comment thread apps/web/src/views/studio/glossary.tsx Resolved
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@screen-gd
screen-gd merged commit 2678e67 into main Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant