Repository navigation
Security: fail CI when a commit adds a secret - #15
Merged
Merged
Conversation
A Comfy API key and a Google API key were both committed to .env.example in the past. GitHub push protection did not stop the Comfy key because it does not know that format. The new workflow runs gitleaks 8.30.1 (checksum-verified) on the commits each pull request or push to main adds. .gitleaks.toml extends the built-in rules with a comfy-api-key rule and allowlists files whose contents only look like credentials. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bottom of the stack: #15 → #16 → #17
Merge order: #15, then #16, then #17.
delete_branch_on_mergeis off, so click Delete branch after each merge; that makes GitHub retarget the next PR tomain.Summary
Adds a CI check that fails when a pull request or a push to
mainadds a secret. A Google API key reached.env.examplein04f8ab5and was only removed by hand in the next commit..agents/is allowlisted because the vendored skill docs use sample tokens in their examples (11 findings in2002dfe, all docs).Evidence
04f8ab5added a live-format Google key to.env.example.After: this config reports
gcp-api-key .env.example@04f8ab5on that commit, and the scan exits 1.mainwith this config: one finding, the same revoked key.no leaks found, exit 0.API_KEY_INVALID.Merge Danger
Door: two-way
Blast Radius: CI
New PRs fail if they add a key-shaped string. A false positive can be allowlisted in
.gitleaks.toml.Summary by CodeRabbit