This repository was archived by the owner on Jun 10, 2026. It is now read-only.
Preserve list contents when CSV column import is cancelled#10077
Closed
Chessing234 wants to merge 1 commit into
Closed
Preserve list contents when CSV column import is cancelled#10077Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Cancelling or entering an invalid column number produced an empty list. Co-authored-by: Cursor <cursoragent@cursor.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Importing a multi-column CSV into a list monitor prompts for a column number. Cancelling that prompt deletes all existing list items (#7313).
Root cause
parseInt(prompt(msg), 10)returnsNaNwhen the user cancels. Mapping rows withrow[NaN - 1]yieldsundefinedfor every row, and the subsequent string filter produces an empty array that replaces the list.Why this fix is correct
Return early when the prompt is cancelled or the column number is out of range, so
setVariableValueis not called and the existing list is left unchanged.Fixes #7313
Made with Cursor