Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 89.62% 89.79% +0.17%
==========================================
Files 13 13
Lines 636 647 +11
Branches 138 139 +1
==========================================
+ Hits 570 581 +11
Misses 54 54
Partials 12 12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Just found https://github.com/codecobblers/dirtyjson by fast googling. May be it have sense to use it here. |
|
Using a library would definitely be better. I’m a bit worried about the library not having received changes since 2017, and @scottkmaxwell not being active in GitHub since 2018. On the other hand, there are no open issues or pull requests in the repository, and worse case scenario we could fork the library. I’ll give it a try. |
|
According to #137 (comment) it won’t work. |
|
@Kiollpt thanks for checking and @Gallaecio thanks for passing the message |
I'm still around, just busy with my day job. It looks like I am not getting my GitHub notifications in email so I'll fix that now. Feel free to use or fork. If you want to just use dirtyjson, I'll try to be responsive to PRs. |
Fixes #53
If we merge this, we should create a separate issue to handle #53 (comment), which probably requires a custom fallback JSON parser.