Skip to content

feat: add support for additional file and volume definitions in score schema#198

Open
lekaf974 wants to merge 1 commit into
score-spec:mainfrom
lekaf974:feat/files-and-volumes-shortland-support
Open

feat: add support for additional file and volume definitions in score schema#198
lekaf974 wants to merge 1 commit into
score-spec:mainfrom
lekaf974:feat/files-and-volumes-shortland-support

Conversation

@lekaf974
Copy link
Copy Markdown

Signed-off-by: lekaf974 matthieu.evrin@gmail.com

Description

What does this PR do?

This PR fix #196 adding short definitions of files and volumes in schema definition

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

… schema

Signed-off-by: lekaf974 <matthieu.evrin@gmail.com>
Copy link
Copy Markdown
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @lekaf974!

LGTM on my side!

Let's have @chris-stephenson review too.

In the meantime, you can already start the branch in score-go using this new file if you want.

Copy link
Copy Markdown
Contributor

@chris-stephenson chris-stephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathieu-benoit
Copy link
Copy Markdown
Contributor

I would suggest we wait for the temporary integration of this in score-go and let's say score-compose to then merge this one and them all in cascade? Just for proof testing. Are you ok with that @lekaf974?

@lekaf974
Copy link
Copy Markdown
Author

I would suggest we wait for the temporary integration of this in score-go and let's say score-compose to then merge this one and them all in cascade? Just for proof testing. Are you ok with that @lekaf974?

Yep sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Shorthand way to define files and volumes

3 participants