Repository navigation
Conversation
* Retain source spelling while classifying block types case-insensitively. * Cover splitter behavior and parse-write round trips with regression tests.
* Preserve source spelling in the parser default. * Provide optional lowercase normalization as middleware.
* Retain citation-key spelling through the public round trip. * Preserve custom field-key casing without implicit normalization.
* Verify richer entry types, fields, dates, annotations, and extended names. * Preserve set, xdata, and custom data-model records without a dialect flag. * Validate the synthetic standard-profile fixture with Biber 2.21.
* Distinguish structural preservation from Biber data-model semantics. * List the separately tested BibLaTeX extensions. * Reserve data-model conversion for explicit, loss-reporting transformations.
|
Hi @claell — same note across all of your July 16 issues and PRs (#567–#597), apologies for the repetition. Closing this. Passing CI isn't evidence the underlying claim is real — it just means generated tests match generated code. The batch's timing, structure, and forward-referenced numbers point to this being AI-generated rather than manually found and checked, and reviewing it properly would take more effort than a targeted pass over the parser myself. If this fixes something you actually hit: open a small, human-verified PR against a reopened issue with a real repro, and I'll review it in good faith. Any nontrivial design or API choice needs to be discussed and agreed first, not decided inside a PR. Please disclose and verify AI-assisted work before submitting going forward. |
2 participants
Summary
@set,@xdata, richer entry types and fields, dates, UTF-8, annotations, extended names, and custom data-model names.Closes #586. Closes #105.
Dependency and commit structure
The first three commits are the exact entry-type case-preservation work already under review in PR #570. The BibLaTeX contract tests and boundary documentation are the final two commits. The branch runs against current
main; after #570 merges, it should be rebased so those prerequisite diffs disappear from this PR.The nested Biber-comment feature from #372 / PR #585 is intentionally not included or claimed by this branch.
Validation
pytest -p no:cacheprovider -W error tests/test_biblatex_contract.py: 4 passed.tests/test_entrypoint.py.--tool --validate-datamodelaccepted the exact synthetic fixture, completed data-model validation, and emitted no warnings.Review note
Most of this PR is an explicit compatibility contract rather than new schema interpretation. Maintainer review should confirm that the parser is intended to remain schema-agnostic and that preserving custom entry/field names without a dialect flag is the correct boundary.
AI assistance
This pull request was prepared with ChatGPT Codex using GPT-5.6 Sol with high reasoning effort. Codex assisted with standards review, fixture design, dependency separation, documentation, and validation. Automated validation is not a substitute for maintainer review.