Skip to content

Honor custom parsing failure comments - #566

Merged
MiWeiss merged 2 commits into
sciunto-org:mainfrom
sapunyangkut:codex/issue-530-parsing-failed-comment
Sep 2, 2026
Merged

MiWeiss merged 2 commits into
sciunto-org:mainfrom
sapunyangkut:codex/issue-530-parsing-failed-comment

Conversation

@sapunyangkut

Copy link
Copy Markdown
Contributor

Summary

  • Honor the active BibtexFormat.parsing_failed_comment template when writing failed blocks.
  • Strengthen the existing regression test for both the default and a custom template.

Fixes #530

Validation

Preserved exact-SHA evidence for this unchanged upstream base and identical patch:

  • pytest tests/test_writer.py::test_write_failed_block: 1 passed
  • pytest tests/test_writer.py: 25 passed
  • configured pre-commit hooks on both changed files: passed

The current no-install checkout lacks pylatexenc, so its fresh focused rerun stopped during collection. No dependencies or dependency files were changed.

AI assistance

This Draft PR was prepared with OpenAI Codex. Automated root-cause analysis, patching, and validation evidence were used; no human self-review is claimed. It remains a draft for maintainer and user review.

@MiWeiss

MiWeiss commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

This Draft PR was prepared with OpenAI Codex. Automated root-cause analysis, patching, and validation evidence were used; no human self-review is claimed. It remains a draft for maintainer and user review.

@sapunyangkut Please review and motivate your PRs in the future; i tend to close ai-only PRs. Exception here, as it is a trivial fix :-)

@MiWeiss
MiWeiss merged commit 36df72e into sciunto-org:main Sep 2, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BibtexFormat.parsing_failed_comment is ignored by the writer

2 participants