Skip to content

Test duplicate key namespaces #575

Closed

Description

@claell

Problem

Library keeps entries and @string definitions in separate key namespaces, but the test suite currently exercises strict duplicate handling only for entries. That leaves two related contracts implicit:

  • duplicate @string keys must fail under the default strict policy; and
  • an entry and an @string definition may legitimately share the same key.

Without explicit coverage, a future change to duplicate detection could either admit duplicate string definitions or incorrectly treat different block types as conflicts.

Proposed coverage

Add focused library tests that verify strict duplicate rejection for String blocks and verify that entry and string keys remain independent namespaces. No production behavior needs to change.

Activity

  1. claell commented on Jul 16, 2026

    @claell
    ContributorAuthor

    A focused test-only implementation is available in draft PR #576: #576

  2. MiWeiss commented on Sep 2, 2026

    @MiWeiss
    Collaborator

    Hi @claell — I'm posting this same note on all of your July 16 issues and PRs (#567–#597), so apologies for the form-letter feel.

    I'm closing this. The batch — 13 issues, 18 PRs, ~3,000 lines, opened within a two-hour window with spec-style language and forward-references to PR numbers that didn't exist yet — reads as AI-generated rather than something you hit and verified by hand. Reviewing it properly would cost me more time than just fixing the parser myself.

    If this is a real bug you've actually hit: reopen it with a concrete repro and a small, human-verified fix, and I'll review it. Any nontrivial design or API choice should be discussed in the issue first, before code is written. Otherwise, please disclose and verify AI-assisted contributions before submitting them in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions