Skip to content

Conversation

@Kleinpenny
Copy link
Contributor

@Kleinpenny Kleinpenny commented Feb 6, 2026

Summary

  • Add train-method selection for RWTHDBIS term typing and taxonomy discovery, including DS-CL pretraining flow and context/no-context fine-tuning paths.
  • Update RWTHDBISLearner examples to expose train_method with explanations and limit inputs for quick runs.
  • Update RWTHDBIS learner documentation with comprehensive training method descriptions:
    • Document all training methods (DS-CL, FT-TC, SKPT) for Term Typing
    • Document training methods (DS-CL + without_context FT-TC, with_context FT-TC) for Taxonomy Discovery
    • Fix class name and import path for Taxonomy Discovery learner
    • Add context generation workflow documentation
    • Update parameter descriptions to match code implementation
    • Add training method selection guidance

Changes

  • Code: Added train_method parameter support in both term typing and taxonomy discovery learners
  • Examples: Updated examples to demonstrate train_method usage with limited inputs for quick testing
  • Documentation: Comprehensive update to rwthdbis_learner.rst with detailed training method descriptions

Test plan

  • /home/yxpeng/anaconda3/envs/ontolearner/bin/python examples/llm_learner_rwthdbis_term_typing.py
  • /home/yxpeng/anaconda3/envs/ontolearner/bin/python examples/llm_learner_rwthdbis_taxonomy_discovery.py

@HamedBabaei
Copy link
Member

Dear @Kleinpenny , thanks for your contribution. We will start reviewing your work shortly.

Copy link
Member

@HamedBabaei HamedBabaei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @Kleinpenny , thanks for all the fixes. I am wondering whether you can confirm whether we need to make any changes to the documentation page as well to reflect the new version of your approach? Other than this, everything seems to be perfect, and the code is ready for merge.

- Add detailed descriptions for all training methods (DS-CL, FT-TC, SKPT)

- Document train_method parameter for both Term Typing and Taxonomy Discovery

- Fix class name and import path for Taxonomy Discovery learner

- Add context generation workflow documentation

- Update parameter descriptions to match code implementation

- Add training method selection guidance
@Kleinpenny
Copy link
Contributor Author

Dear @Kleinpenny , thanks for all the fixes. I am wondering whether you can confirm whether we need to make any changes to the documentation page as well to reflect the new version of your approach? Other than this, everything seems to be perfect, and the code is ready for merge.

Yes, updated!

@HamedBabaei
Copy link
Member

Dear @Kleinpenny , thanks for all the fixes. I am wondering whether you can confirm whether we need to make any changes to the documentation page as well to reflect the new version of your approach? Other than this, everything seems to be perfect, and the code is ready for merge.

Yes, updated!

Thank you!

@HamedBabaei HamedBabaei merged commit fb69ee6 into sciknoworg:dev Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants