Repository navigation
Conversation
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
|
|
||
| - The release manager must be a **maintainer** of the | ||
| https://github.com/conda-forge/scikit-learn-feedstock repository to be able to publish | ||
| on `conda-forge`. This can be changed by editing the `recipe/meta.yaml` file in the |
There was a problem hiding this comment.
Unrelated to the changes here, but this file was renamed to recipe/recipe.yaml in conda-forge/scikit-learn-feedstock#290.
There was a problem hiding this comment.
Good point, PR more than welcome to fix it 🙏! Ping me and I'll merge it quickly.
| and the final release afterwards should include only minor documentation changes | ||
| and bug fixes. Any major enhancement or new feature should be excluded. | ||
|
|
||
| - Create the release branch `{{ version_short }}.X` directly in the main repository, |
There was a problem hiding this comment.
Maybe this is obvious to maintainers, but it could be made explicit that "main repository" references scikit-learn here (and not scikit-learn-release).
| <https://github.com/scikit-learn/scikit-learn/actions/workflows/publish_pypi.yml>`_ | ||
| again, but this time to upload the artifacts to the real https://pypi.org/. To do | ||
| so, replace `testpypi` with `pypi` in the "Run workflow" form. | ||
| - In the same `publish.yml` workflow run, a release team member can |
There was a problem hiding this comment.
Having not gone through the process yet, this part is not totally clear to me: Does this happen during the first run? And if so, should there be a note above that only the test upload should be approved first? Or does this require a re-trigger of the workflow (as in the old version)?
There was a problem hiding this comment.
It's in the same workflow run, basically you have manual approval in the middle of the workflow something like this:
- manual trigger (
workflow_dispatch) - build wheels
- manual approval to upload to testPyPI
- upload to testPyPI when approved
- here you can install from testPyPI and run the tests locally to make 100% sure everything looks good
- manual approval to upload to PyPI
- upload to PyPI when approved
| https://github.com/scikit-learn/scikit-learn-release/actions/workflows/publish.yml | ||
|
|
||
| - The `publish.yml` workflow will first build the wheel, then ask for | ||
| approval from a release team member to upload it to `testPyPI` (through |
There was a problem hiding this comment.
Just for my understanding: can this be the same person that started the workflow?
There was a problem hiding this comment.
There is a setting to enable self-review, I think it is not enabled for now (not 100% sure I need to double-check).
Co-authored-by: Anne Beyer <anne.beyer@mailbox.org>
|
@lesteve The switch the CRLF line endings makes it impossible to view the lines changed by this PR. I suppose this is caused by a bug in GitHub. I pushed a commit to revert the line endings back to LF only. EDIT: for reference, it seems that CPython developers also faced this bug in the passed and decided to hard-code LF as a result in |
ogrisel
left a comment
There was a problem hiding this comment.
The doc change LGTM from a cursory glance but I guess the real check will happen once @betatim gives it a try.
@lesteve I just added a suggestion to make it explicit that manual upload should only serve as a fallback in case trusted publishing does not work anymore (and would require changing settings on the pypi.org side).
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
This is an first attempt to update the maintainer doc for releasing from the https://github.com/scikit-learn/scikit-learn-release repo following scikit-learn/scikit-learn-release#18.
Comments more than welcome!
The real test will be when @betatim will actually try to do the release. It's quite likely that the doc can be further improved then.
cc @betatim @virchan @jeremiedbb.