Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

[WIP] FIX CDClassifier with n_jobs != 1 in py36 (#114)#117

Open
vene wants to merge 5 commits into
scikit-learn-contrib:masterfrom
vene:cdefpkl
Open

[WIP] FIX CDClassifier with n_jobs != 1 in py36 (#114)#117
vene wants to merge 5 commits into
scikit-learn-contrib:masterfrom
vene:cdefpkl

Conversation

@vene

@vene vene commented Jun 10, 2017

Copy link
Copy Markdown
Contributor

However, the change breaks the test test_debiasing_l1l2 on my box, I can't tell why.

@vene vene requested review from fabianp and mblondel June 10, 2017 06:29
@vene

vene commented Jun 10, 2017

Copy link
Copy Markdown
Contributor Author

(rebased onto #118 to benefit from actually relevant continuous integration)

@vene vene force-pushed the cdefpkl branch 2 times, most recently from 178d48a to f06f871 Compare June 10, 2017 09:28

@fabianp fabianp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nothing to add :-)

@aldanor

aldanor commented Mar 28, 2018

Copy link
Copy Markdown
Contributor

@fabianp @mblondel Could this get possibly merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants