All files actions (remove and get)#88
Open
Sashkoiv wants to merge 3 commits into
Open
Conversation
added 3 commits
October 30, 2019 17:07
Pass `--all` flag to retrieve files to the current directory or specify the destination directory after the flag. - ampy --port /board/serial/port get --all - ampy --port /board/serial/port get --all ./destination/
To delete all files from the board: ampy --port /board/serial/port rm --all
Member
|
To get all files, I would want to avoid adding a new option. Why not just do that if '/' is passed as the REMOTE_FILE argument? $ ampy get / Similarly, for the remove all command, this looks much more cleaner - $ ampy rmdir / |
Author
|
Hey @devxpy , good idea but not that obvious in my opinion. |
Contributor
|
A better name for the option might be --recursive, which corresponds to the -R/-r/--recursive option found in the Unix/Linux commands rm and cp. |
Contributor
|
I definitely prefer having an option rather than making "/" magic. |
curiouswala
added a commit
that referenced
this pull request
Apr 16, 2026
) PR #85 cherry-pick: add logging.debug() calls at the start of every Files method (get, ls, mkdir, put, rm, rmdir, run). Logging is silent by default and activates when the caller configures the 'ampy.files' logger at DEBUG level. User-facing output (print) is unchanged. PR #88 EISDIR decision: auto-falling back from rm to rmdir when a directory is encountered was intentionally not implemented — it would silently delete directory contents without user confirmation. The existing "Is a directory (use rmdir to remove)" error is safer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes I need to remove all files from the board, get all files or put all files to the board. Due to that,
I'm using those locally and pretty happy, so I'm suggesting small modifications to the original code.
Also for using vscode debugging I'm running the tool as a module and have added an extra record to
.gitignore.I'll appreciate any comments=)