Support verbose command option#85
Conversation
|
This is a good idea, thanks! But the implementation you proposed looks a little ugly to me. I'd be much more comfortable with a logging based solution. Then we can just have the |
Added info for 'verbose' flag and updated the list of supported commands.
|
Hello @devxpy here are the changes for the logging implementation. I have updated the branch to your latest changes and made the logging implementation on top....though (for a reason that I do not know) github sees as commits of this pull request also commits that took place after the initial submission of the Pull Request. If you want the Pull Request to be cleaner, I could close this PR and open a new one. Waiting for your feedback. |
ftylitak
force-pushed
the
support-verbose-messages
branch
from
c5ee7ed to
c0427a3
Compare
ftylitak
force-pushed
the
support-verbose-messages
branch
from
c0427a3 to
8b83a71
Compare
…o/ampy into support-verbose-messages
|
@devxpy finally did a reset and rebase to get rid of all the irrelevant commits. I hope now it would be easier to review. |
) PR #85 cherry-pick: add logging.debug() calls at the start of every Files method (get, ls, mkdir, put, rm, rmdir, run). Logging is silent by default and activates when the caller configures the 'ampy.files' logger at DEBUG level. User-facing output (print) is unchanged. PR #88 EISDIR decision: auto-falling back from rm to rmdir when a directory is encountered was intentionally not implemented — it would silently delete directory contents without user confirmation. The existing "Is a directory (use rmdir to remove)" error is safer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 participants
Add support to "-v, --verbose" option to the cli.
This will enable printing of progress messages regarding the files that are being handled at the moment.
Affected operations:
(also some whitespaces have been removed automatically by the linter.)