Stale child cleanup and non-blocking KVM WebSocket connect#9
Open
nesvet wants to merge 2 commits into
Open
Conversation
nesvet
force-pushed
the
feat/stale-child-cleanup
branch
from
d847b3a to
0668150
Compare
This was referenced Jun 28, 2026
nesvet
force-pushed
the
feat/stale-child-cleanup
branch
from
0668150 to
65fcd78
Compare
nesvet
changed the title
Spawn connect work via asyncio.create_task so the WebSocket receive loop can process control frames during long child startup (tornado#2941). Schedule log writes on the IOLoop; cancel in-flight connect on close. Remove explicit websocket_ping_interval. Add connect unittest.
nesvet
force-pushed
the
feat/stale-child-cleanup
branch
from
65fcd78 to
99c58c8
Compare
nesvet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Orphaned
nojava-ipmi-kvmrc-*children block noVNC ports after unclean server shutdown.Long KVM container startup must not block the WebSocket receive loop.
Changes
main.py— stale cleanup on startup, SIGTERM, atexit; remove explicitwebsocket_ping_intervalkvm_handler.py—create_taskfor connect;_schedule_writefor log lines; cancel in-flight connect on close;_safe_writetests/test_kvm_handler_connect.py— connect does not blockon_messageConnect work is spawned per tornado#2941.
Requires nojava-ipmi-kvm#38.
Test plan
docker rmTested on ASUS ASMB8-iKVM firmware 1.14.2.
Closes #7