Extract KVM UI assets and replace alert() with status banner#10
Open
nesvet wants to merge 1 commit into
Open
Conversation
3 tasks
Author
Move inline CSS/JS to app.core.*; keep form in DOM; wire logout cookie cleanup; pass version and server_labels for cache bust and multi-host labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes server UI issues without changing the WebSocket protocol: invalid inline CSS,
alert()for notices, logout not clearing cookies, fragile connect DOM replacement, and missing context for multi-host deployments.Changes
main.py—version=__version__for cache busting;server_labelsfor multi-host displaystatic/app.core.css,static/app.core.js— extracted core UI behaviourtemplates/base.tpl,templates/index.tpl,templates/index_instant.tpltemplates/_resolution_select.tpl,templates/_server_field.tpl,templates/_session_log.tplalert()Test plan
versionquery paramTested on ASUS ASMB8-iKVM firmware 1.14.2: single-host connect, error notice in banner, labels shown when
server_labelsconfigured.Closes #8