Skip to content

Migrating the build process of the _cmd and _champ libraries from the setup.py file to CMake#398

Open
ye11owSub wants to merge 6 commits intoschrodinger:masterfrom
ye11owSub:refactor_setup_script
Open

Migrating the build process of the _cmd and _champ libraries from the setup.py file to CMake#398
ye11owSub wants to merge 6 commits intoschrodinger:masterfrom
ye11owSub:refactor_setup_script

Conversation

@ye11owSub
Copy link
Copy Markdown
Contributor

No description provided.

@ye11owSub ye11owSub force-pushed the refactor_setup_script branch 2 times, most recently from b0da6a5 to 21a65d2 Compare September 13, 2024 16:08
@ye11owSub ye11owSub changed the title WIP: Refactor setup script WIP: Refactor setup.py Sep 13, 2024
@ye11owSub ye11owSub force-pushed the refactor_setup_script branch 5 times, most recently from cf588bf to a46dcf2 Compare September 13, 2024 17:10
@JarrettSJohnson
Copy link
Copy Markdown
Member

Looks good, but please continue to keep create_shadertext.py around.

@ye11owSub ye11owSub force-pushed the refactor_setup_script branch 7 times, most recently from 9d9656b to f4baefc Compare May 12, 2025 15:22
@JarrettSJohnson
Copy link
Copy Markdown
Member

Thanks for your efforts. I will say for the purposes of this (and future) PRs, I would ask to leave the champ module untouched for now.

@ye11owSub ye11owSub force-pushed the refactor_setup_script branch 13 times, most recently from 595799e to 42f0f8f Compare May 17, 2025 16:29
@ye11owSub ye11owSub force-pushed the refactor_setup_script branch 23 times, most recently from 1306c80 to 2071e34 Compare May 22, 2025 23:05
@ye11owSub
Copy link
Copy Markdown
Contributor Author

ye11owSub commented May 26, 2025

Hi @JarrettSJohnson
Can you please tell me why I shouldn't change the champ module?
I split the champ into a separate cmake, because I wanted to use it as a first step towards using pybind11 to create Python extensions

@JarrettSJohnson
Copy link
Copy Markdown
Member

Hi, I haven't been following this PR too much, but just wanted to mention that I think the original goal for what I thought this PR would go has gone completely further than the scope that I would have liked (and this hasn't been the first time this has happened).

I think eventually we want to get there, but it really is important to me that we keep the building process of incentive and open-source in-sync. The original refactoring of setup.py was fine, but the full cmake-ify (if I were to consider something like scikit-build-core or something) of this something I'd like to handle myself and incrementally.

@ye11owSub
Copy link
Copy Markdown
Contributor Author

hey @JarrettSJohnson
Is there any chance that you could share your plan, so we can discuss the steps that need to be taken in this PR in order to switch to CMake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants