"Lazy" property in Service annotation: Define service as lazy#223
Closed
alber999 wants to merge 13 commits into
Closed
"Lazy" property in Service annotation: Define service as lazy#223alber999 wants to merge 13 commits into
alber999 wants to merge 13 commits into
Conversation
Author
|
This test will always fail: traits added in PHP 5.4 but tests run on PHP 5.3.29 All other tests pass ok (except allowed failures) |
Author
|
This works perfectly in full-stack symfony framework, but in a standalone application one more dependency should be added: "symfony/proxy-manager-bridge" |
|
@alber999 Nice work! As for tests, you can mark trait tests skipped for PHP 5.3- |
solution for schmittjoh#235 as proposed by Ener-Getick in schmittjoh#235 (comment)
check if cache folder exists
Contributor
|
@alber999 can you rebase your branch? this was fixed in the TraitTest |
This reverts commit 6593189.
Author
|
@wodka done! |
| $this->scope, | ||
| $this->public, | ||
| $this->abstract, | ||
| $this->lazy, |
Collaborator
There was a problem hiding this comment.
It should be the last one to avoid BC breaks.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wouldn't it be nice to define lazy services in Service annotation?
Just by adding "ocramius/proxy-manager" as dependency and handling Service "lazy" property you can make it. I hope you find this pull request useful
Cheers