#195 bug fix dont throw null pointer when rows is empty#197
Open
polyglotpiglet wants to merge 1 commit into
Open
#195 bug fix dont throw null pointer when rows is empty#197polyglotpiglet wants to merge 1 commit into
polyglotpiglet wants to merge 1 commit into
Conversation
chbatey
requested changes
Mar 22, 2018
Member
chbatey
left a comment
chbatey
left a comment
There was a problem hiding this comment.
Thank you. Two minor changes then LGTM
| public static class ThenBuilder { | ||
| private List<CqlType> variable_types; | ||
| private List<Map<String, ? extends Object>> rows; | ||
| private List<Map<String, ? extends Object>> rows = new ArrayList<>(); |
| stubFor(post(urlEqualTo(PRIME_PREPARED_PATH)).willReturn(aResponse().withStatus(200))); | ||
| PrimingRequest pr = PrimingRequest.preparedStatementBuilder() | ||
| .withQuery("select * from people") | ||
| .withThen(PrimingRequest.then().withVariableTypes(TEXT)) |
Member
There was a problem hiding this comment.
Variable types are the ? in prepared statements, yours has none so can remove the withVariableTypes. This is a stubbed tests so doesn't really matter but the real server would reject this priming request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.