chore(vulnerability):SP-4012 include component status in block responses#61
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds per-component error reporting by introducing Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
db77b19 to
93c40d3
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
protobuf/scanoss/api/vulnerabilities/v2/scanoss-vulnerabilities.swagger.json (1)
486-488:⚠️ Potential issue | 🟡 MinorPre-existing: malformed keys
"requirement="and"version="in example.The example object at Lines 487–488 has
"requirement="and"version="as keys (with trailing=). These should be"requirement"and"version". This originates from the proto file's example string.
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Around line 10-16: Add the missing comparison link for the new release tag:
append a link entry for [0.29.0] at the bottom of CHANGELOG.md matching the
existing pattern (e.g., "[0.29.0]:
https://github.com/scanoss/papi/compare/v0.28.0...v0.29.0") so the release list
includes a proper compare URL for the 0.29.0 section.
In `@protobuf/scanoss/api/vulnerabilities/v2/scanoss-vulnerabilities.proto`:
- Line 254: The example JSON for ComponentsCpesResponse contains malformed keys
with stray equals signs; locate the example string (the example field inside the
ComponentsCpesResponse example literal) and remove the '=' characters from the
keys "requirement=" and "version=" so they become "requirement" and "version"
respectively (apply to both component objects in the example) to produce valid
JSON.
- Line 377: The JSON example in the description for
ComponentVulnerabilityResponse (and the duplicate in
ComponentsVulnerabilityResponse) incorrectly uses the CPE field name "cpes" due
to copy-paste; update those description strings to replace the "cpes":[...]
array with "vulnerabilities":[...] (and ensure the example vulnerability objects
match the expected vulnerability schema if present) so the example reflects a
vulnerability response rather than a CPE response.
🧹 Nitpick comments (1)
protobuf/scanoss/api/vulnerabilities/v2/scanoss-vulnerabilities.swagger.json (1)
343-349: New error fields lacktitle/descriptionin the schema.All other properties in
v2ComponentCpesInfoandv2ComponentVulnerabilityInfoinclude atitleordescription. The newerror_messageanderror_codefields are missing them. Adding brief descriptions (e.g., "Error message describing why component processing failed" and "Error code categorizing the failure") would keep the schema documentation consistent.
protobuf/scanoss/api/vulnerabilities/v2/scanoss-vulnerabilities.proto
Outdated
Show resolved
Hide resolved
protobuf/scanoss/api/vulnerabilities/v2/scanoss-vulnerabilities.proto
Outdated
Show resolved
Hide resolved
93c40d3 to
5033537
Compare
Summary by CodeRabbit
New Features
Documentation
Chore