CLDSRV-954: use native crc32 and crc32c#6226
Open
leif-scality wants to merge 1 commit into
Open
Conversation
Contributor
Hello leif-scality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
3a9f4f7 to
7f2629b
Compare
jonathan-gramain
approved these changes
Jul 9, 2026
fredmnl
approved these changes
Jul 9, 2026
Comment on lines
+2
to
+4
| // Native CRC32/CRC32C via the AWS Common Runtime (aws-crt): hardware-accelerated | ||
| // and dramatically faster than the pure-JS @aws-crypto/crc32{,c}. aws-crt is | ||
| // already loaded in-process by @aws-sdk/crc64-nvme-crt below. |
Contributor
There was a problem hiding this comment.
Comment could be shorter
Suggested change
| // Native CRC32/CRC32C via the AWS Common Runtime (aws-crt): hardware-accelerated | |
| // and dramatically faster than the pure-JS @aws-crypto/crc32{,c}. aws-crt is | |
| // already loaded in-process by @aws-sdk/crc64-nvme-crt below. | |
| // Native hardware-accelerated, faster than pure-JS @aws-crypto/crc32{,c} |
BourgoisMickael
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.