Skip to content

CLDSRV-945: Support cross account rate limiting#6225

Open
tmacro wants to merge 5 commits into
development/9.3from
improvement/CLDSRV-945/support_cross_account_rate_limiting
Open

CLDSRV-945: Support cross account rate limiting#6225
tmacro wants to merge 5 commits into
development/9.3from
improvement/CLDSRV-945/support_cross_account_rate_limiting

Conversation

@tmacro

@tmacro tmacro commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
  • Cloudserver now passes the bucket owner canonicalId to Vault using targetAccount if it has been previously cached.
    • (Vault's side) If targetAccount differs from the requesting account targetAccount's rate limit config is retrieved and returned in response

@bert-e

bert-e commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Hello tmacro,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-945 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.14

  • 9.4.0

Please check the Fix Version/s of CLDSRV-945, or the target
branch of this pull request.

@tmacro tmacro changed the title Improvement/cldsrv 945/support cross account rate limiting CLDSRV-945: Support cross account rate limiting Jul 9, 2026
@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.00%. Comparing base (055ae1b) to head (f03007f).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/api.js 93.66% <100.00%> (+0.16%) ⬆️
lib/metadata/metadataUtils.js 94.60% <100.00%> (+1.99%) ⬆️

... and 3 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6225      +/-   ##
===================================================
+ Coverage            84.93%   85.00%   +0.06%     
===================================================
  Files                  206      206              
  Lines                13366    13374       +8     
===================================================
+ Hits                 11353    11368      +15     
+ Misses                2013     2006       -7     
Flag Coverage Δ
file-ft-tests 68.40% <100.00%> (+0.01%) ⬆️
file-ft-tests-null-compat 68.97% <100.00%> (+0.07%) ⬆️
kmip-ft-tests 28.31% <81.81%> (+0.02%) ⬆️
mongo-v0-ft-tests 69.59% <100.00%> (-0.04%) ⬇️
mongo-v1-ft-tests 69.65% <100.00%> (+0.04%) ⬆️
multiple-backend 36.81% <100.00%> (+0.03%) ⬆️
s3c-ft-tests-v0 64.13% <45.45%> (+0.02%) ⬆️
s3c-ft-tests-v0-null-compat 64.19% <45.45%> (+0.02%) ⬆️
s3c-ft-tests-v1 64.13% <45.45%> (+0.03%) ⬆️
sur-tests 36.68% <100.00%> (+0.03%) ⬆️
sur-tests-inflights 37.70% <100.00%> (+0.02%) ⬆️
unit 70.65% <100.00%> (+0.15%) ⬆️
utapi-v2-tests 34.58% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants