Handle BucketAlreadyExists races and bump arsenal for MPU afterEach fix#6222
Handle BucketAlreadyExists races and bump arsenal for MPU afterEach fix#6222benzekrimaha wants to merge 4 commits into
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
ab63d85 to
2cae9bc
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_pull_requests, create_integration_branches |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## development/9.3 #6222 +/- ##
================================================
Coverage 84.93% 84.94%
================================================
Files 206 206
Lines 13366 13374 +8
================================================
+ Hits 11353 11360 +7
- Misses 2013 2014 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ARSN-613 makes Mongo createBucket return BucketAlreadyExists instead of silent idempotence. Continue bucket creation follow-up when a concurrent call already created the metastore entry (freshStartCreateBucket), and fetch the existing MPU shadow bucket when getMPUBucket races. Issue: CLDSRV-919
2cae9bc to
6178ad8
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
Pull in ARSN-613 (paired with this cloudserver change) so MPU shadow bucket creation returns BucketAlreadyExists on concurrent races. Issue: CLDSRV-919
71b7d71 to
0a09689
Compare
Summary
Fix MPU shadow-bucket creation races in cloudserver callers and bump arsenal to 8.4.20 (ARSN-613).
ARSN-613 makes
MongoClientInterface.createBucket()returnBucketAlreadyExistson concurrent duplicates instead of silent idempotence. Cloudserver must handle that contract:freshStartCreateBucket: continueaddToUsersBucket/ transient cleanup when the metastore entry already exists.getMPUBucket: onBucketAlreadyExists, fetch and return the existing MPU shadow bucket.This fixes the intermittent
afterEachfailure inmpuVersion.js("We encountered an internal error") whenListMultipartUploadsraces on MPU shadow bucket creation during test cleanup.Paired with Arsenal PR #2672 (ARSN-613).
Issue: CLDSRV-919