Send X-Scal-Request-Uids (not x-scal-request-id) on the management config poll

[delthas]

The management config-overlay poll (lib/management/poll.js,
loadRemoteOverlay) sent the werelogs req_id chain under the wrong
header name x-scal-request-id. Rename the outgoing header to
x-scal-request-uids, which matches cloudserver's own reader in
lib/server.js. The value (log.getSerializedUids()) is unchanged.

Pure rename: no dual-send. Also exports loadRemoteOverlay and adds a
focused unit test asserting the outgoing request carries
x-scal-request-uids and not x-scal-request-id.

Part of the OS-1089 reqUids-propagation audit. Note: the receiving
config/overlay endpoint on pensieve-api doesn't declare this header in
its swagger params, but pensieve reads it via a global middleware
(WithRequestId), so it applies to every endpoint regardless. Related
pensieve-side reqUids work: PSVAPI-131.

Issue: CLDSRV-948

[bert-e]

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[codecov]

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
9661	1	9660	0

View the full list of 2 ❄️ flaky test(s)

"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With v4 signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 206 times)

Stack Traces | 0.017s run time

We encountered an internal error. Please try again.

should create a bunch of objects and their versions::put and head object with versioning With v4 signature on versioning suspended then enabled bucket w/ null version should create a bunch of objects and their versions

Flake rate in main: 13.81% (Passed 668 times, Failed 107 times)

Stack Traces | 600s run time

Timeout of 600000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (.../test/versioning/objectHead.js)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[benzekrimaha]

LGTM.
side note and not blocking :
blobserver's lib/management/poll.js has the same x-scal-request-id header , we might need a follow up ticket

[delthas]

Re blobserver: it looks EOL (last real commit Feb 2021), so I don't think a follow-up is worth it. Let me know and I can create one as needed.