Skip to content

Bump arsenal to 8.5.6#2772

Open
delthas wants to merge 3 commits into
development/9.5from
improvement/BB-791/bump-arsenal-8.5.6
Open

Bump arsenal to 8.5.6#2772
delthas wants to merge 3 commits into
development/9.5from
improvement/BB-791/bump-arsenal-8.5.6

Conversation

@delthas

@delthas delthas commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Bump backbeat's arsenal dependency 8.5.2 → 8.5.6.

This pulls in the getApplicableRules fix from ARSN-597: day-based lifecycle actions with Days=0 now survive rule selection (the guard changed from a truthy if (rule.Expiration.Days) to !== undefined). Without it, the v1 lifecycle task path drops Days=0 rules at getApplicableRules and never expires the objects — so the "empty this bucket" (Days=0) feature (BB-791) is incomplete on v1.

Same 8.5.x line as the current pin, so a low-risk forward bump. Also bumps the package version to 9.5.0-preview.4.

Issue: BB-791

delthas added 2 commits July 9, 2026 10:43
Pull in the getApplicableRules fix (ARSN-597) so day-based lifecycle
actions with Days=0 survive rule selection; without it the v1 lifecycle
task path drops Days=0 rules and never expires the objects.

Issue: BB-791
@bert-e

bert-e commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.39%. Comparing base (295fa38) to head (f28a791).

Additional details and impacted files

Impacted file tree graph
see 3 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.22% <ø> (ø)
Core Library 81.56% <ø> (-0.08%) ⬇️
Ingestion 70.13% <ø> (ø)
Lifecycle 79.71% <ø> (ø)
Oplog Populator 85.83% <ø> (ø)
Replication 61.56% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.5    #2772      +/-   ##
===================================================
- Coverage            75.42%   75.39%   -0.03%     
===================================================
  Files                  201      201              
  Lines                13868    13868              
===================================================
- Hits                 10460    10456       -4     
- Misses                3398     3402       +4     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.09% <ø> (ø)
api:routes 8.87% <ø> (ø)
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 10.40% <ø> (-0.60%) ⬇️
ingestion 12.30% <ø> (ø)
lib 7.79% <ø> (-0.01%) ⬇️
lifecycle 19.20% <ø> (ø)
notification 1.01% <ø> (ø)
oplogPopulator 0.14% <ø> (ø)
replication 18.74% <ø> (ø)
unit 53.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@delthas delthas requested review from a team, DarkIsDude and benzekrimaha July 9, 2026 08:47
arsenal 8.5.6 inserted a `log` parameter into the LifecycleConfiguration
constructor (now (xml, log, config)), shifting `config` to the third
position. Pass the config as the third argument so _buildStorageClasses
gets it instead of undefined (which threw
"Cannot read properties of undefined (reading 'replicationEndpoints')").

Issue: BB-791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants