Bump arsenal to 8.5.6#2772
Open
delthas wants to merge 3 commits into
Open
Conversation
Pull in the getApplicableRules fix (ARSN-597) so day-based lifecycle actions with Days=0 survive rule selection; without it the v1 lifecycle task path drops Days=0 rules and never expires the objects. Issue: BB-791
Contributor
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## development/9.5 #2772 +/- ##
===================================================
- Coverage 75.42% 75.39% -0.03%
===================================================
Files 201 201
Lines 13868 13868
===================================================
- Hits 10460 10456 -4
- Misses 3398 3402 +4
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DarkIsDude
approved these changes
Jul 9, 2026
arsenal 8.5.6 inserted a `log` parameter into the LifecycleConfiguration constructor (now (xml, log, config)), shifting `config` to the third position. Pass the config as the third argument so _buildStorageClasses gets it instead of undefined (which threw "Cannot read properties of undefined (reading 'replicationEndpoints')"). Issue: BB-791
benzekrimaha
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump backbeat's arsenal dependency
8.5.2 → 8.5.6.This pulls in the
getApplicableRulesfix from ARSN-597: day-based lifecycle actions withDays=0now survive rule selection (the guard changed from a truthyif (rule.Expiration.Days)to!== undefined). Without it, the v1 lifecycle task path dropsDays=0rules atgetApplicableRulesand never expires the objects — so the "empty this bucket" (Days=0) feature (BB-791) is incomplete on v1.Same 8.5.x line as the current pin, so a low-risk forward bump. Also bumps the package version to
9.5.0-preview.4.Issue: BB-791