Repository navigation
Fix deploy: eject artifact wrote to the read-only cell mount; repair the kind e2e harness - #49
Merged
Merged
Conversation
…the kind e2e harness Every `datamk deploy` has failed since ADR 0008: `datamk run` writes the eject artifact to `.cell/materialize/<table>.sql` as a hard error, and a Builder pod mounts the cell read-only from the ConfigMap, so the init Job died with "Read-only file system" on the first transform. - engine: `DATAMK_MATERIALIZE_DIR` redirects the eject artifacts, mirroring `DATAMK_LOG=off` for the same read-only case. Env-only, empty ignored, default unchanged. Unit test added. - Dockerfile: `DATAMK_MATERIALIZE_DIR=/tmp/materialize`, the scratch emptyDir the pods already mount. - kind e2e: pin MinIO and mc to quay.io (Docker Hub denies anonymous `minio/*` pulls, so the infra phase could not start); route discovery picks the `@<major>` path now that the spec also documents `/`, `/context`, and `/openapi.json`. `make e2e` passes end-to-end including the freshness capstone. The harness is still not run in CI, which is how this shipped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0145XunDkqmp2ot1zXQo4Sxc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every
datamk deployhas failed since ADR 0008 shipped.datamk runwrites the eject artifact to.cell/materialize/<table>.sqlas a hard error (src/engine/mod.rs), and Builder pods mount the cell read-only from the ConfigMap, so the init Job died withRead-only file systemon the first transform.DATAMK_MATERIALIZE_DIRredirects the eject artifacts, mirroringDATAMK_LOG=offfor the same read-only case. Env-only, empty value ignored, default path unchanged. Unit test added.DATAMK_MATERIALIZE_DIR=/tmp/materialize, the scratch emptyDir the pods already mount.mcpinned toquay.iotags (Docker Hub now denies anonymousminio/*pulls, so the infra phase could not start on any machine). Route discovery selects the@<major>path now that the spec also documents/,/context,/context/{route}, and/openapi.json.docs/guides/incremental.md.Verification
make e2epasses end-to-end on a fresh kind cluster, including the freshness capstone (execution 2 published, same Server pod picked it up, no restart).cargo test --bin datamk: 915 passed.cargo clippy --all-targets --all-features -D warnings: clean.cargo fmt --check: clean.Found, not fixed
apply.rs:118server-side-applies the content-addressed init Job. A failed Job whose pod template is unchanged (same image tag) is a no-op on re-deploy, anddeployre-reports the stale failure. A fixed image under the same tag cannot retry without deleting the Job by hand. Separate issue.The harness is still never run in CI, which is how the deploy regression shipped.
🤖 Generated with Claude Code
https://claude.ai/code/session_0145XunDkqmp2ot1zXQo4Sxc