Repository navigation
feat(computers): a release publishes chromium composed, and a compose of the same inputs pulls it (M8.60) - #705
Open
earakely-scale wants to merge 2 commits into
Conversation
… of the same inputs pulls it (M8.60) Each release composes chromium from its own wheels on an amd64 and an arm64 runner, probes it, and joins the two images by their digests as one index in ghcr.io/scaleapi/agentenv-computers; the wheel records each arch's key, image and the lock it was composed from. A compose with that wheel takes the release's lock rather than resolving one, finds its key in the record, and records the released image by digest, pulled rather than built; anything that changes the key composes as before. The release's computer jobs never hold a release back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
M8.60 (FD-5908), PR 1 of 2: each release publishes chromium composed, and a compose of the same inputs pulls it.
Today anyone who uses chromium composes it: Docker, a package resolve from Ubuntu's archive, PyPI and download URLs, minutes per arch, and emulation for the other arch. A release now composes it once per arch, probes it, and publishes it; an install of that release pulls it by digest instead of resolving and building. PR 2 (scaleapi) promotes it to the hub as the env
chromium.Design note: M8.60: Publish chromium with each release, outcome and decisions 1a (amended: boot from ghcr), 2a, 3a, 4a, Nov 15.
What changes
publish-pypi.yml,.github/scripts/release_computers.py):computer-buildcomposes chromium from the release's own wheels on an amd64 and an arm64 runner, once the protocol is on PyPI and the base computers are published. It probes each at full and hands its local registry's storage on. It holds no token that pushes.computer-publish(infra_build.py publish-computers, standard library and docker only) joins the two images as one index inghcr.io/scaleapi/agentenv-computers, from that storage, keeping their digests, so each is the image its probe booted. It records each arch's key, image by digest and the lock it was composed from.infra-recordputs that record in the wheel'spublished_images.jsonascomputers;verify-recordchecks the index and its images against the registry; the release notes list the index.composer.py,published_images.py):reused,published) and probes it as any reuse is probed. Nothing is resolved or built.computers/README.md,browsers/README.md, AGENTS.md.Decided while building, for your review
The design note lists 8, in its last section. The ones worth a look:
chromiumhelper and the store rule for alias ids (decision 3) move out of this PR, into a small framework PR that ships with PR 2.agentenv-computersis a new GHCR package: private until an org admin makes it public. Until then installs compose as before, and the release warns.How it was tested
Unit:
test_computer_env.py, on a fake Docker and registry): a compose of what the release published pulls it with nothing resolved or built and its computer over the released index; a record of another key, or an image the registry won't give, composes as before; an arch released beside one composed here, and an index the registry won't give, join an index in the store.published_images_test.py): its locks, images and index found, a record that isn't one refused, a registry named by its port.publish-computersjoins each app's platform manifests (an attestation set aside) into one index and records it, refuses anything a compose didn't write and pushes nothing, and refuses an index that doesn't name exactly its images;verify-recordchecks each composed computer;write --computersrecords them.End to end, on agent-environments-admin VMs, amd64 (c8i.4xlarge, KVM) and arm64 (m7g.4xlarge), the release as the workflow runs it:
computer-build: the framework built as a wheel and pinned as the release pins it, installed with protocol 0.1.555 from PyPI, chromium composed natively and probed ready on each arch (129 files resolved, about 3 minutes each).computer-publish: the two registries' storage merged, andinfra_build.py publish-computersrun as is, a second local registry standing in for ghcr: one index of the two images, their digests kept.verify-recordpassed on the record.Chaos, on amd64, each a fresh install with
--no-emulate:Integration,
browser_computer_test.py, a new test: chromium composed again in fresh stores with a record of the module's own compose (the local registry standing in for ghcr) takes every arch's image from it, resolves and builds nothing, and the browser it deploys boots that image. The whole module passed on amd64 (31 passed, 1 skipped); the new test and gate 3 passed on arm64.Not run before merge: the jobs on GitHub's runners and the push to ghcr, which only a release tag runs.
After merge
agentenv-computerspackage public once it exists.chromiumenv.🤖 Generated with Claude Code