Repository navigation
test(drivers): the codex-computer-use idle test gives two calls in a row room on a busy runner - #700
Merged
Conversation
…row room on a busy runner
With IDLE_S at 0.2 s, a busy CI runner let the driver close the REPL between the test's set and get, so the get found a
fresh one ("None in 6467") and the test failed. The idle window is now 1 s, and the wait for the REPL to close is 5 s.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
deleted the
edgararakelyan/codex-driver-idle-test-flake
branch
November 15, 2026 17:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tst/unit/drivers/codex_computer_use_driver_test.py::test_a_repl_left_idle_is_closed_without_another_call_and_its_session_starts_afreshfailed on a busy CI runner (#699's
unit (2/2)):IDLE_Sto 0.2 s. On that runner more than 0.2 s passed between itsset 1and itsget, so thedriver's sweep closed the REPL in between, and
getfound a fresh one.IDLE_Sis now 1 s, a module constant that says why: well over two calls in a row on a busy runner._gonewaits up to 5 s for the REPL to close, instead of 2 s.afresh. It takes about a second longer.
Proof
main's recent unit runs pass, so it's a timing flake; this widens the window it needs.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Gives the idle test more room on busy runners.
No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "test(drivers): the codex-computer-use id..." · Reviewed by Greptile