Repository navigation
test(browser): the nudge test times the second capture from before the frame, not from the first capture - #675
Closed
earakely-scale wants to merge 1 commit into
Closed
earakely-scale wants to merge 1 commit into
earakely-scale wants to merge 1 commit into
Conversation
…e frame, not from the first capture The control arms its NUDGE_S wait before its first capture's task sends it, so the first capture is sent a moment after the wait starts and the second can follow it by a hair under NUDGE_S (0.49966 s on a loaded runner). Timing the second from before the frame call is what the control promises. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
test_a_tab_behind_the_active_one_is_framed_once_a_second_capture_nudges_itchecked that the second capture came at leastNUDGE_S(0.5 s) after the first. It failed on #673'sunit (2/2)with 0.49966 s.The cause:
_nudged_capturestarts the first capture withensure_futureand then armsasyncio.wait(..., timeout=NUDGE_S). The first capture's request goes out on the loop's next turn, a moment after the wait started, so the second capture can follow it by a hair underNUDGE_S. The control is right; the test measured from the wrong point. It now times the second capture from before theframecall, which the second capture can't precede by less thanNUDGE_S.Testing
test_browser_recording.py, five times🤖 Generated with Claude Code


Confidence Score: 5/5
This test-only change appears safe to merge.Summary
Updates the nudge test to measure the second capture from before
frame, rather than from the first capture.Reviews (1) · Last reviewed commit: "test(browser): the nudge test times the ..." · Reviewed by Greptile