Repository navigation
fix: two timing-tight tests, and agent installers retry a download curl gives up on - #664
Merged
Merged
Conversation
…er delay is timed from detection The auto-release test held Alt for 50 ms, so on a loaded runner the hold could end before the drag reached the queue, and the keys went up first. The hold is now 300 ms and the drag 1 s. The trigger-delay test measured the delay from the `delayed` event, which is stamped once the fire starts, a little after the provoking call the delay actually runs from; at 60x that came to 119.98 s. It now measures from `detected`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
curl's --retry passes over some transient failures, such as a reset HTTP/2 stream (exit 92), which failed Claude Code installs. --retry-all-errors needs curl 7.71, and an installer runs on hosts with any curl, so a failed fetch is tried once more instead. A second failure still stops the install with curl's own exit code. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Three of the failures that most often turned
main's Local backends runs red over the last week.test_the_automatic_release_waits_out_a_busy_queue(unit): the 50 ms hold could end before the drag reached the queue on a loaded runner, so the keys went up first (['key_down', 'key_up', 'drag']). The hold is now 300 ms and the drag 1 s.test_a_reply_waits_its_delay_and_hours_and_its_writes_name_the_fire(integration): a delay runs from the provoking call, read as it's detected, but the test measured it from thedelayedevent, stamped once the fire starts, which came to 119.977 s at 60x. It now measures fromdetected, with 1 s of slack for a stamp trailing its reading.curl --retry 3passes over a reset HTTP/2 stream (exit 92), which failed Claude Code installs. A failed fetch now gets one more go.--retry-all-errorswould need curl 7.71, and an installer runs on hosts with any curl. A second failure still stops the install with curl's own exit code.How it was tested
pytest packages/agentenv-protocol/tests/test_computer_queue.py: 45 passed. With a 120 ms stall injected betweencomputer_keyboard_downandcomputer_drag, the old values fail with['key_down', 'key_up', 'drag']and the new ones pass.pytest tst/unit/agents/: 951 passed.fetchagainst a fake curl that exits 92: no failure or one failure downloads the file; two stop the script with exit 92 underset -euo pipefail.integration-local-slowon this PR.🤖 Generated with Claude Code


Confidence Score: 5/5
This PR appears safe to merge.Summary
Adds one extra download attempt to five agent installers and gives two timing-sensitive tests more room.
No actionable issues found.
Reviews (1) · Last reviewed commit: "fix(agents): an installer's download get..." · Reviewed by Greptile