Skip to content

test(env_gateway): the never-ready site tests don't wait out the 30s margin - #625

Merged
andrewpark-scaleai merged 1 commit into
mainfrom
andrewpark/website-ready-margin-tests
Nov 13, 2026
Merged

andrewpark-scaleai merged 1 commit into
mainfrom
andrewpark/website-ready-margin-tests

Conversation

@andrewpark-scaleai

@andrewpark-scaleai andrewpark-scaleai commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Why

The goal is faster agentenv-framework CI with no test weakened. Two unit tests of a site that never says it's ready each waited out the full 30s WEBSITE_READY_MARGIN_S. That's 60s of unit-tier time. The tests next to them already set the margin to 0.

What

  • test_a_site_that_never_says_it_is_ready_fails_the_deploy_naming_why and test_a_site_whose_ready_answers_no_website_readiness_is_never_ready_and_the_deploy_says_so set WEBSITE_READY_MARGIN_S to 0. Together they take 2s instead of 63s.

Coverage

I broke the readiness wait in env_gateway_provider.py eight ways:

  • The two tests still fail when a not-ready site counts as ready, when the error leaves out the reason, when a bad readiness answer counts as ready, when there's no deadline, and when the timeout_s argument is ignored.
  • They miss changes to the margin itself. So do main's versions of these tests, which never checked how long the wait was. This change loses no coverage.

Verification

  • All 266 tests in env_gateway_provider_test.py pass.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Two never-ready tests set WEBSITE_READY_MARGIN_S to zero to avoid unnecessary waiting.

  • Never-ready readiness tests skip the extra 30-second wait.

Reviews (2) · Last reviewed commit: "test(env_gateway): the never-ready site ..." · Reviewed by Greptile

@andrewpark-scaleai
andrewpark-scaleai requested a review from a team as a code owner November 11, 2026 20:29
@andrewpark-scaleai
andrewpark-scaleai force-pushed the andrewpark/website-ready-margin-tests branch from b2f64c9 to a51bf37 Compare November 13, 2026 21:20
@andrewpark-scaleai
andrewpark-scaleai enabled auto-merge (squash) November 13, 2026 21:20
@andrewpark-scaleai
andrewpark-scaleai merged commit 82ddeb8 into main Nov 13, 2026
36 checks passed
@andrewpark-scaleai
andrewpark-scaleai deleted the andrewpark/website-ready-margin-tests branch November 13, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants