Skip to content

ci: pull the base images at once - #624

Merged
andrewpark-scaleai merged 1 commit into
mainfrom
andrewpark/parallel-base-image-pulls
Nov 13, 2026
Merged

andrewpark-scaleai merged 1 commit into
mainfrom
andrewpark/parallel-base-image-pulls

Conversation

@andrewpark-scaleai

@andrewpark-scaleai andrewpark-scaleai commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Why

The goal is faster agentenv-framework CI with no test weakened. Each Docker shard runs mirror_base_images.py, which pulls its 9 base images one after another. In CI that takes 25s, and the slowest single pull takes 5s. It runs on every Docker shard, including the slow tier's longest.

What

  • mirror_base_images.py pulls all the bases at the same time. It still switches dockerd to the containerd store first, and each image keeps its own retries and tag.
  • test_the_bases_are_pulled_at_once holds both fake pulls at a barrier. It fails on main's serial code (BrokenBarrierError) and passes with this change.

Expected effect

About 15s off every Docker shard. That's an estimate from the CI step times. This PR's own run will show the measured time.

Verification

  • tst/unit/test_mirror_base_images_script.py passes, 10 tests.
  • An independent review found no defects.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable defects were found.

Summary

Pulls Docker base images concurrently while keeping Docker setup ahead of all pulls.

  • Base-image pulls now run at the same time.

Reviews (2) · Last reviewed commit: "ci: pull the base images from mirror.gcr..." · Reviewed by Greptile

@andrewpark-scaleai
andrewpark-scaleai requested a review from a team as a code owner November 11, 2026 20:29
@andrewpark-scaleai
andrewpark-scaleai force-pushed the andrewpark/parallel-base-image-pulls branch from d1e428c to 7e65933 Compare November 13, 2026 21:20
@andrewpark-scaleai
andrewpark-scaleai enabled auto-merge (squash) November 13, 2026 21:20
@andrewpark-scaleai
andrewpark-scaleai merged commit 3ccd5f4 into main Nov 13, 2026
36 checks passed
@andrewpark-scaleai
andrewpark-scaleai deleted the andrewpark/parallel-base-image-pulls branch November 13, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants