Repository navigation
fix(ci): the durations refresh keeps the times of a tier the run skipped - #623
Merged
Merged
Conversation
earakely-scale
approved these changes
Nov 13, 2026
andrewpark-scaleai
force-pushed
the
andrewpark/durations-keep-skipped-tiers
branch
from
November 13, 2026 20:50
a4eb76d to
83b3e72
Compare
andrewpark-scaleai
deleted the
andrewpark/durations-keep-skipped-tiers
branch
November 13, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The goal is faster agentenv-framework CI with no test weakened. The shard tables are rebuilt from a run's JUnit reports with
.github/scripts/slow_test_durations.py, and the script rewrites the table whole. When a run skips a tier, as main's run 43079720062 skipped the installer tier, every unit of that tier drops out of the table. Those shards then balance by the median, not by real times.What
test_a_file_the_reports_have_no_test_of_keeps_its_timesfails on main's script and passes with this change.test_a_reported_split_file_drops_its_tests_the_reports_dont_havepins the renamed-test behaviour.Verification
tst/unit/test_slow_test_durations_script.pypasses, 5 tests.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
The refresh keeps old durations for files missing from the reports, provided those files still exist.
Review covered the full PR because the previous-review ancestry and merge-base checks did not pass. Tests were inspected but not run.
Reviews (2) · Last reviewed commit: "fix(ci): the durations refresh keeps the..." · Reviewed by Greptile