Repository navigation
Conversation
A run's step_overrides now reach run_code: `step_overrides[<step id>].args` is merged over the step's stored args, the run's keys winning, the same way run_container_unit_tests_verifier adds overridden env_vars to its stored ones. One stored task can then be run with per-run script inputs instead of a new task version per input. An args override that isn't an object is refused before the step touches a sandbox. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Closing: the caller that needed per-run run_code args went back to creating a task version per input, so nothing depends on this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_codeignored a run'sstep_overrides. A caller that needed per-run script inputs had to create a new task version for each input, for example one copy of a QC task per item it checks, just to set itsrun_codesteps'args.step_overrides[<step id>].argsis now merged over the step's storedargs, and the run's keys win.run_container_unit_tests_verifierapplies the same rule toenv_vars. Anargsoverride that isn't an object is refused before the step touches a sandbox.Validation: three unit tests in
tst/unit/task_step/test_run_code.pycover the merge, an override aimed at another step, and the refusal. I couldn't run the suite locally, so CI is the check of record.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; the previous null-argument issue is fixed.Summary
run_codemerges per-runargsover stored arguments without changing the stored values.Reviews (2) · Last reviewed commit: "fix(run_code): refuse an explicit null a..." · Reviewed by Greptile