Skip to content

docs(local): a supervisor kills the run's process group and retries a sandbox not fully gone - #564

Merged
earakely-scale merged 2 commits into
mainfrom
edgararakelyan/fd-5375-recipe-docs
Nov 9, 2026
Merged

earakely-scale merged 2 commits into
mainfrom
edgararakelyan/fd-5375-recipe-docs

Conversation

@earakely-scale

@earakely-scale earakely-scale commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Part of FD-5375.

Two additions to the recipe in #555 for cleaning up after a killed run (run_bundle's docstring, .env.example and local_sandbox_ids()'s docstring):

  • Kill the run's whole process group. A VM-mode local sandbox runs its commands on this machine. After a kill, teardown finds what they left by an environment marker read from /proc, which macOS doesn't allow, so on macOS only killing the group stops them. On Linux it also stops commands mid-start.
  • Keep a sandbox whose terminate_sandbox raises, and retry it. Since fix(local): retain sandbox folders after incomplete teardown #561, that raise means the sandbox isn't fully gone: Docker couldn't list or remove one of its objects, or one of its processes survived. Its folder is the identity a retry needs.

Docs only: no code or behavior changes.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The documentation changes appear safe to merge.

Summary

Updates the local sandbox cleanup recipe. No runtime behavior changes.

  • Supervisor notes now say to isolate a run before killing its process group.
  • Recovery notes tell supervisors to keep sandbox folders when termination raises.

Reviews (2) · Last reviewed commit: "docs(local): a supervisor starts the run..." · Reviewed by Greptile

… sandbox not fully gone

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread src/agent_env/bundle/run.py Resolved
…its group spares the supervisor

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@earakely-scale
earakely-scale merged commit 4937bc1 into main Nov 9, 2026
34 checks passed
@earakely-scale
earakely-scale deleted the edgararakelyan/fd-5375-recipe-docs branch November 9, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant