Repository navigation
fix(triggers): wait for a slow executor up to its own timeout, not 30 s (FD-5333) - #544
Merged
Merged
Conversation
… s (FD-5333) An executor holds message/send open until its task ends, so the 30 s read timeout failed every fire whose contact took longer, even though the reply usually still landed. The send now reads for the executor's timeout_seconds (never less than 30 s); connect and task polls keep 30 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
earakely-scale
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A trigger's
nlaction calls its executor (an AI-played contact) over A2A. The executor holdsmessage/sendopen until it has replied, but the gateway gave that call a fixed 30 s timeout. Any contact slower than 30 s failed the fire: the trigger was marked failed and its later actions (like anotify) never ran, even though the reply usually still landed. The executor's own timeout (executor_timeout_seconds, 120 by default) never came into play.In ML's prod runs this cut off 22% of contact replies (40% on Holiday Rush, 25% on Tree Removal). Linear: FD-5333.
Change
timeout_seconds(never less than 30 s, so shorter settings behave as before).ReadTimeout, trigger re-armed).Tests
Two new unit tests against a local fake executor that answers late:
Both fail without the fix. The gateway and trigger unit tests pass: 941 with the fix, 939 on main, no failures either side.
Worth a look
"configuration": {"blocking": false}) and relying on the existing polling would avoid the long-held call. It's left out here because it depends on every executor server supporting it. It would matter if a proxy in front of an executor drops idle connections before the executor timeout.TRIGGER_BARRIER_TIMEOUT_S) is unchanged: a barriered call is still answered after 30 s while the fire carries on.🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
The executor’s
message/sendnow uses a read timeout ofmax(30, timeout_seconds). Connecting and task polls keep their 30-second limits.Reviews (1) · Last reviewed commit: "fix(triggers): wait for a slow executor ..." · Reviewed by Greptile