Include more detail about the assumptions of the shell#1002
Open
ScalaWilliam wants to merge 1 commit intosbt:developfrom
Open
Include more detail about the assumptions of the shell#1002ScalaWilliam wants to merge 1 commit intosbt:developfrom
ScalaWilliam wants to merge 1 commit intosbt:developfrom
Conversation
Especially for Windows users.
eed3si9n
reviewed
Mar 12, 2021
| -------------- | ||
|
|
||
| This page assumes you've [installed sbt 1][Setup]. | ||
| This page assumes you've [installed sbt 1][Setup] and you are running a Bash/UNIX shell on macOS, Linux or WSL ([Windows Subsystem for Linux](https://docs.microsoft.com/en-us/windows/wsl/install-win10)). |
Member
There was a problem hiding this comment.
Why does the system shell matter so much here? Are we trying to preclude Windows console?
Contributor
Author
There was a problem hiding this comment.
These instructions would not work on the Windows default console, and some new users might be just confused what this all means and skip the tutorial.
Contributor
Author
There was a problem hiding this comment.
And many people still don't know about WSL being available on Windows at all.
Member
There was a problem hiding this comment.
If the user is already familiar with Windows console, I don't want them to switch to using WSL.
I'd much rather document touch equivalent on console together, which is
type nul >> build.sbt
?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Especially for Windows users.