Skip to content

Add Query.get_meta()#299

Open
chrisimcevoy wants to merge 1 commit intosbdchd:mainfrom
chrisimcevoy:query-get-meta
Open

Add Query.get_meta()#299
chrisimcevoy wants to merge 1 commit intosbdchd:mainfrom
chrisimcevoy:query-get-meta

Conversation

@chrisimcevoy
Copy link
Copy Markdown

Adds get_meta() to Query

closes #249

@chrisimcevoy
Copy link
Copy Markdown
Author

I'll take a look at the lint error.

@chrisimcevoy
Copy link
Copy Markdown
Author

 + mypy tests typings
typings/django/db/models/sql/query.pyi:95:27: error: Missing type parameters for generic type "Options"  [type-arg]
Found 1 error in 1 file (checked 693 source files)

Interesting. Same return type as upstream.

The django-types Options uses the generic type parameter (_M) several times (source). I notice that django-stubs still has the generic type parameter on its Options, but it appears to be otherwise unused. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

db.models.sql.Query lacks get_meta() definition

1 participant