Pass HTTP client instances through when creating children#12
Open
acdha wants to merge 4 commits intosaymedia:masterfrom
Open
Pass HTTP client instances through when creating children#12acdha wants to merge 4 commits intosaymedia:masterfrom
acdha wants to merge 4 commits intosaymedia:masterfrom
Conversation
Contributor
Author
|
An experimental test implementation is in acdha/remoteobjects@1c8c820 - see https://github.com/acdha/remoteobjects/tree/issue-12-linked-clients. It still needs tests to confirm that the same HTTP client is being passed around everywhere but it appears to work in casual testing. |
This avoids passing in None, which will get a default client which might not contain credentials, proxy configuration, etc.
This passes through the http client to preserve credentials, proxy info, etc.
Contributor
Author
|
We have been running the attached code w/o issue for around a bit over a year without incident |
|
Hi Chris, would you be able to write at least a couple of tests to demonstrate this? I'm just starting to look at some of the old pull requests and seeing some tests would help clarify the intent of this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a project which uses an API which returns relative URLs and requires HTTP authentication and at times access via a proxy. This has exposed several cases where the HTTP client wasn't being passed to a child object, which would cause the initial get() to work and then subsequent accesses to fail.
acdha/remoteobjects@746ce0b passes the client to Link
acdha/remoteobjects@aa1eaf1 passes the client in to a RemoteObject during post()
The major remaining area is handling collections: currently it's complicated by the fact that a List or Dict doesn't pass a reference to itself in when creating a subfield so the fix will need to pass a reference to self or self._http from ListObject.seqmethod through into the underlying field decode. I'm currently handling this with a quick hack to fix it up on the way out of getitem but it seems like this will require changing field decode() to accept an optional http parameter to pass the value down.