Skip to content

fix!: ShapeTag generation for nullable non-blittable types #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sator-imaging merged 4 commits into from
Aug 30, 2026
Merged

fix!: ShapeTag generation for nullable non-blittable types #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b979d41
Fix ShapeTag generation to omit '?' suffix for non-blittable types
google-labs-jules[bot] Aug 30, 2026
4771029
Refactor ShapeTag nullable struct check to target blittable structs
google-labs-jules[bot] Aug 30, 2026
12580eb
Refactor ShapeTag nullable check to explicitly detect non-blittable s…
google-labs-jules[bot] Aug 30, 2026
41801cc
Simplify ShapeTag nullable check for non-blittable structs
google-labs-jules[bot] Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/ZeroSerializerGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,6 +1736,10 @@ private static void CreateShapeTag(ITypeSymbol typeSymbol, StringBuilder shapeTa
{
var underlying = nullableType.TypeArguments[0];
CreateShapeTag(underlying, shapeTagBuilder);
if (underlying is INamedTypeSymbol named && named.TypeKind == TypeKind.Struct && !TryGetBlittableStructByteCount(named, out _))
{
return;
}
shapeTagBuilder.Append('?');
return;
}
Expand Down
2 changes: 1 addition & 1 deletion tests/ShapeTagAndHashTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public void EnumClassViewTest()
[Fact]
public void SchemaSignatureTestsModelViewTest()
{
string schemaSignatureExpected = "v1/{blittable{int,enum:short},{int,enum:byte},blittable{int,enum:short}[],{},blittable{},{enum:byte,enum:short}?,enum:byte[],enum:ulong[],int?,bool?}";
string schemaSignatureExpected = "v1/{blittable{int,enum:short},{int,enum:byte},blittable{int,enum:short}[],{},blittable{},{enum:byte,enum:short},enum:byte[],enum:ulong[],int?,bool?}";
Assert.Equal(SchemaSignatureTestsModelView.ShapeTag, schemaSignatureExpected);
Assert.Equal(SchemaSignatureTestsModelView.ShapeHash, XXHash32.HashToUInt32(schemaSignatureExpected));
}
Expand Down
Loading