Skip to content

Add ZEROS009 diagnostic for StructLayout attribute on non-struct types - #88

Merged
sator-imaging merged 2 commits into
mainfrom
add-zeros009-structlayout-warning-16613021054791758980
Aug 28, 2026
Merged

Add ZEROS009 diagnostic for StructLayout attribute on non-struct types#88
sator-imaging merged 2 commits into
mainfrom
add-zeros009-structlayout-warning-16613021054791758980

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Adds ZEROS009 warning diagnostic when StructLayout attribute is applied to non-struct types marked with ZeroSerializer.


PR created automatically by Jules for task 16613021054791758980 started by @sator-imaging

Emit ZEROS009 warning when a type decorated with ZeroSerializer is not a struct and has a StructLayout attribute applied. Also include violation and compliant unit tests in DiagnosticTests.cs.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Comment thread src/ZeroSerializerGenerator.cs Outdated
@sator-imaging
sator-imaging marked this pull request as ready for review August 28, 2026 06:54
@sator-imaging
sator-imaging merged commit 971dd25 into main Aug 28, 2026
4 checks passed
@sator-imaging
sator-imaging deleted the add-zeros009-structlayout-warning-16613021054791758980 branch August 28, 2026 06:54
@sator-imaging
sator-imaging restored the add-zeros009-structlayout-warning-16613021054791758980 branch August 28, 2026 06:54
@sator-imaging
sator-imaging deleted the add-zeros009-structlayout-warning-16613021054791758980 branch August 28, 2026 06:54
@github-actions github-actions Bot added the enhancement New feature or request label Aug 28, 2026
@sator-imaging sator-imaging changed the title Add ZEROS009 diagnostic for StructLayout attribute on non-struct types Add ZEROS009 diagnostic for StructLayout attribute on non-struct types Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant